Public scan — anyone with this URL can view this analysis. Sign up to track your own repos privately, run scheduled re-scans, and get AI fix prompts via your dashboard.

Charliesj0129/subhft

https://github.com/Charliesj0129/subhft · scanned 2026-06-17 01:25 UTC (1 month, 2 weeks ago)

419 raw signals (0 security + 419 graph)

File as issue Image

UNIFIED Repobility · multi-layer engine · AI coders

Complete repo analysis

Last scanned 1 month, 2 weeks ago · v2 · last Δ -28.8 (diff) · 400 actionable findings from 1 signal source. 19 repeated signals grouped for readability. Security checks, system graph analysis, and verified AI-agent feedback are merged into one review queue.

JSON

77.8% cov · 400 findings

Severity distribution — click a segment to filter

Active filters: excluding tests × Reset all

Severity: Critical 2 High 0 Medium 31 Low 235 9-Layer: Software Security Quality Integrity Frontend Hardware Data Network Cicd Source: Security checks 0 System graph 400 Crowd 0 Layer: Software 24 Network 17 Hardware 2 Security 2 Cicd 2 Quality 353

Exclude dismissed / FP Exclude test files

Bug-class explainers. Each card groups findings of the same shape — these are the patterns most likely to ship to prod and reappear in future scans unless you systematically fix the cause, not just the instance.

Duplicates & near-duplicates 3 findings

What it is: Same function copy-pasted into multiple modules with minor variations.

Why it matters: Each copy drifts independently — bug fixes apply to one, miss the others.

How AI causes it: AI completes the same pattern in each file rather than refactoring to a shared helper.

Fix approach: Extract the duplicated logic into the most general module both call sites already import. Add tests at the helper level.

3 matching findings on this repo

low Near-duplicate function bodies in 4 places
low Near-duplicate function bodies in 2 places repo-level
low Near-duplicate function bodies in 3 places

View all duplicates & near-duplicates findings →

Legacy markers 12 findings

What it is: TODO, FIXME, XXX, HACK comments. Often indicate a known-broken path the author meant to fix.

Why it matters: Each marker is an unfinished thought. Production code shouldn't ship with debt that's documented but not tracked.

How AI causes it: AI mirrors the style of the codebase, so existing TODOs propagate into new code.

Fix approach: Convert each into a ticket. Delete the comment when the ticket lands. Use a pre-commit hook to block new TODOs without an issue link.

12 matching findings on this repo

low Old/deprecated-named symbol `test_bus_mode_rust_typed_overrides_legacy` in test…
low Old/deprecated-named symbol `empty_legacy` in tests/unit/test_contract_refresh_…
low Old/deprecated-named symbol `test_parse_table_from_filename_trades_maps_to_trad…
low Old/deprecated-named symbol `skipped_legacy` in tests/unit/test_order_id_map_tt…
low Old/deprecated-named symbol `test_legacy` in tests/unit/test_wal_coverage.py:66
low Old/deprecated-named symbol `gap_legacy` in tests/unit/test_market_data_service…
low Old/deprecated-named symbol `test_ensure_price_scaled_views_no_legacy` in tests…
low Old/deprecated-named symbol `20_legacy` in tests/unit/test_alpha_experiments.py…
low Old/deprecated-named symbol `alpha_legacy` in tests/unit/alpha/test_cluster.py:…
low Old/deprecated-named symbol `l7_audit_columns_detection_failed_defaulting_legac…
low Old/deprecated-named symbol `_emit_or_legacy` in src/hft_platform/notifications…
low Old/deprecated-named symbol `market_data_backup` in research/tools/legacy/parqu…

View all legacy markers findings →

Commented-out code 132 findings

What it is: Lines of source that were intentionally disabled but never deleted.

Why it matters: Git already remembers history — commented code rots, becomes wrong, and adds noise to diffs.

How AI causes it: AI sometimes comments out broken code instead of fixing it. Reviewers approve out of inertia.

Fix approach: Delete. Trust `git log`. If you really need to remember, save it in a notes file under `docs/`.

12 matching findings on this repo

info Commented-code block (5 lines) in tests/unit/test_feature_backtest_adapter.py:2…
info Commented-code block (7 lines) in tests/unit/test_risk_dlq_snapshot.py:69
info Commented-code block (5 lines) in tests/unit/test_order_adapter_coverage_new.py…
info Commented-code block (5 lines) in tests/unit/test_audit_writer_cross_thread.py:…
info Commented-code block (5 lines) in tests/unit/test_recorder_health.py:121
info Commented-code block (8 lines) in tests/unit/test_market_data_service.py:72
info Commented-code block (6 lines) in tests/unit/test_quote_connection_pool.py:609
info Commented-code block (5 lines) in tests/unit/test_reconciliation_resilience.py:…
info Commented-code block (6 lines) in tests/unit/test_normalizer_coverage.py:959
info Commented-code block (6 lines) in tests/unit/test_contracts_runtime_r1r2.py:48
info Commented-code block (6 lines) in tests/unit/test_market_data_service_coverage.…
info Commented-code block (5 lines) in tests/unit/test_system_shutdown.py:193

View all commented-out code findings →

Config drift 8 findings

What it is: Settings duplicated across env files, Docker compose, K8s, and code defaults, all with slightly different values.

Why it matters: Production behaviour depends on whichever copy your loader reads first. Subtle bugs in staging that don't reproduce in dev.

How AI causes it: AI writes new config from memory rather than reading the existing source.

Fix approach: Pick one source of truth (env vars + a settings module). Have every other place import from there. Lint for duplicates in CI.

8 matching findings on this repo

critical Possible secret in config/clickhouse_init_users.sh config/clickhouse_init_users.sh:9
info Commented-code block (6 lines) in tests/unit/test_shioaji_config.py:110
low Old/deprecated-named symbol `loop_v1` in tests/unit/config/test_schema_strict.p…
low Old/deprecated-named symbol `loop_v1` in tests/unit/config/test_loader_loop_bin…
low Old/deprecated-named symbol `test_risk_config_missing_preserves_old` in tests/i…
low Old/deprecated-named symbol `Loop_v1` in src/hft_platform/config/loader.py:22
low Old/deprecated-named symbol `loop_v1` in src/hft_platform/config/schema.py:84
info Commented-code block (5 lines) in src/hft_platform/config/schema.py:90

View all config drift findings →

For AI agents: Voting guide (TP/FP) MCP manifest Stdio wrapper SARIF Integrate Findings queue Vote TP/FP on findings to calibrate the engine.

For AI agents + API integrations

Email me when this repo regresses

Free. We re-scan periodically; new criticals → your inbox. No signup required for the scan itself.

API access

This page is publicly accessible at: https://repobility.com/scan/c6a8b6dd-3444-443a-9bf3-a503a781bf61/

To check status programmatically (no auth required):

curl -s https://repobility.com/api/v1/public/scan/c6a8b6dd-3444-443a-9bf3-a503a781bf61/

Important — please don't re-submit the same URL repeatedly. The submission endpoint is idempotent: re-submitting the same git URL returns this same scan_token, not a new one. To re-scan this repo, sign up free and use the dashboard.