← Back to scan
File as GitHub Issue repo: topjohnwu/Magisk

Push this scan report to topjohnwu/Magisk

Click the green button below to open GitHub’s new-issue form, pre-filled with the report title, summary table, top findings, and an embedded score-card image. No authentication needed — you review on GitHub before submitting. Repobility is credited as the scanner.

Embedded score card image

This image will render at the top of the issue body. Hosted on Repobility, refreshes automatically after re-scans.

Repobility score card

Issue title

Python Subprocess Shell True

Curate findings to include

Pick exactly which findings appear in the issue body. By default the top 5 are included. Uncheck noise, check what matters.

Top 5 (default)
Severity Rule Title File:line
CRIT MINED022 [MINED022] C Strcpy: strcpy/strcat dont bounds-check; use strncpy or snprintf. native/src/init/mount.cpp:54
CRIT MINED022 [MINED022] C Strcpy: strcpy/strcat dont bounds-check; use strncpy or snprintf. native/src/core/scripting.cpp:80
CRIT MINED022 [MINED022] C Strcpy: strcpy/strcat dont bounds-check; use strncpy or snprintf. native/src/core/deny/logcat.cpp:95
CRIT SEC084 [SEC084] JS: require() with non-literal: require(<variable>) loads arbitrary modules — eq… app/core/src/main/java/com/topjohnwu/ma…:108
HIGH MINED034 [MINED034] Python Subprocess Shell True: subprocess(..., shell=True) enables command inje… scripts/env.py:120
HIGH MINED004 [MINED004] Weak Crypto: MD5/SHA1/DES/RC4 used for security context (not just checksums). scripts/boot_patch.sh:138
HIGH MINED004 [MINED004] Weak Crypto: MD5/SHA1/DES/RC4 used for security context (not just checksums). scripts/app_functions.sh:92
HIGH MINED004 [MINED004] Weak Crypto: MD5/SHA1/DES/RC4 used for security context (not just checksums). native/src/boot/sign.rs:21
HIGH MINED003 [MINED003] Rust Unwrap In Prod: .unwrap() panics if None/Err. Acceptable in tests; risky … tools/rustup-wrapper/src/main.rs:21
HIGH MINED003 [MINED003] Rust Unwrap In Prod: .unwrap() panics if None/Err. Acceptable in tests; risky … native/src/core/build.rs:21
HIGH MINED003 [MINED003] Rust Unwrap In Prod: .unwrap() panics if None/Err. Acceptable in tests; risky … native/src/boot/build.rs:21
HIGH MINED041 [MINED041] Rust Unimplemented Macro: unimplemented!() panics. Same as todo!() but convent… native/src/base/derive/decodable.rs:63
HIGH SEC085 [SEC085] JS: child_process.exec with non-literal: child_process.exec with user-derived in… app/core/src/main/java/com/topjohnwu/ma…:7
HIGH SEC085 [SEC085] JS: child_process.exec with non-literal: child_process.exec with user-derived in… app/core/src/main/java/com/topjohnwu/ma…:14
HIGH SEC085 [SEC085] JS: child_process.exec with non-literal: child_process.exec with user-derived in… app/core/src/main/java/com/topjohnwu/ma…:14
HIGH SEC128 [SEC128] Async function without await — fire-and-forget Promise (AI mistake): Async call … app/apk/src/main/java/com/topjohnwu/mag…:66
HIGH SEC128 [SEC128] Async function without await — fire-and-forget Promise (AI mistake): Async call … app/apk/src/main/java/com/topjohnwu/mag…:55
HIGH SEC128 [SEC128] Async function without await — fire-and-forget Promise (AI mistake): Async call … app/apk-ng/src/main/java/com/topjohnwu/…:80
HIGH MINED029 [MINED029] Kotlin Null Bang: x!! throws NullPointerException if x is null. Bypasses Kotli… app/build-logic/src/main/java/Plugin.kt:25
HIGH MINED029 [MINED029] Kotlin Null Bang: x!! throws NullPointerException if x is null. Bypasses Kotli… app/apk/src/main/java/com/topjohnwu/mag…:94
HIGH MINED029 [MINED029] Kotlin Null Bang: x!! throws NullPointerException if x is null. Bypasses Kotli… app/apk-ng/src/main/java/com/topjohnwu/…:120
HIGH SEC029 [SEC029] Server-Side Request Forgery (SSRF) — outbound HTTP from user input: Outbound HTT… app/core/src/main/java/com/topjohnwu/ma…:94
HIGH SEC029 [SEC029] Server-Side Request Forgery (SSRF) — outbound HTTP from user input: Outbound HTT… app/apk/src/main/java/com/topjohnwu/mag…:27
HIGH SEC029 [SEC029] Server-Side Request Forgery (SSRF) — outbound HTTP from user input: Outbound HTT… app/apk-ng/src/main/java/com/topjohnwu/…:241
HIGH MINED108 `self.ret` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:119
HIGH MINED108 `self.hook_target` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:117
HIGH MINED108 `self.cpp_fn_type` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:114
HIGH MINED108 `self.hook_target` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:113
HIGH MINED108 `self.arg_list_name` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:115
HIGH MINED108 `self.init_args` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:108
HIGH MINED108 `self.ret` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:118
HIGH MINED108 `self.args` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:109
HIGH MINED108 `self.arg_list_cpp` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:64
HIGH MINED108 `self.arg_list_cpp` used but never assigned in __init__ native/src/core/zygisk/gen_jni_hooks.py:61
HIGH MINED134 Binary file `app/gradle/wrapper/gradle-wrapper.jar` committed in source repo app/gradle/wrapper/gradle-wrapper.jar:1
HIGH MINED115 Action `actions/upload-artifact` pinned to mutable ref `@v7` .github/workflows/build.yml:193
HIGH MINED115 Action `actions/download-artifact` pinned to mutable ref `@v8` .github/workflows/build.yml:174
HIGH MINED115 Action `actions/checkout` pinned to mutable ref `@v6` .github/workflows/build.yml:171
HIGH MINED115 Action `actions/upload-artifact` pinned to mutable ref `@v7` .github/workflows/build.yml:148
HIGH MINED115 Action `actions/download-artifact` pinned to mutable ref `@v8` .github/workflows/build.yml:132
HIGH MINED115 Action `actions/checkout` pinned to mutable ref `@v6` .github/workflows/build.yml:129
HIGH MINED115 Action `actions/upload-artifact` pinned to mutable ref `@v7` .github/workflows/build.yml:110
HIGH MINED115 Action `actions/download-artifact` pinned to mutable ref `@v8` .github/workflows/build.yml:96
HIGH MINED115 Action `actions/checkout` pinned to mutable ref `@v6` .github/workflows/build.yml:93
HIGH MINED115 Action `actions/checkout` pinned to mutable ref `@v6` .github/workflows/build.yml:64
HIGH MINED115 Action `actions/upload-artifact` pinned to mutable ref `@v7` .github/workflows/build.yml:49
HIGH MINED115 Action `actions/upload-artifact` pinned to mutable ref `@v7` .github/workflows/build.yml:42
HIGH MINED115 Action `actions/checkout` pinned to mutable ref `@v6` .github/workflows/build.yml:23
HIGH RUSTSEC-2023-0071 rsa: RUSTSEC-2023-0071 native/src/Cargo.lock
HIGH SEC005 [SEC005] Command Injection Risk: Unsafe shell execution or eval of user input. app/stub/src/main/java/com/topjohnwu/ma…:138
HIGH SEC013 [SEC013] Path Traversal — User Input in File Path: User-controlled input used in file pat… app/core/src/main/java/com/topjohnwu/ma…:26
MED SEC012 [SEC012] ZipSlip — Archive Path Traversal: Archive extraction without path validation all… app/core/src/main/java/com/topjohnwu/ma…:131
MED SEC134 [SEC134] AI scaffold leftover — Lorem ipsum / example.com / John Doe in code: Lorem ipsum… app/core/src/main/java/com/topjohnwu/ma…:47
MED SEC045 [SEC045] eval()/exec() on stored or user-supplied data: eval() and exec() on data — even … app/apk-ng/src/main/java/com/topjohnwu/…:90
MED SEC045 [SEC045] eval()/exec() on stored or user-supplied data: eval() and exec() on data — even … app/apk-ng/src/main/java/com/topjohnwu/…:96
MED SEC045 [SEC045] eval()/exec() on stored or user-supplied data: eval() and exec() on data — even … app/apk-ng/src/main/java/com/topjohnwu/…:9
MED MINED111 Bare except continues silently scripts/env.py:74
MED SEC005 [SEC005] Command Injection Risk: Unsafe shell execution or eval of user input. scripts/env.py:120
LOW COMP001 [COMP001] High cognitive complexity: Function `ensure_jdk` has cognitive complexity 8 (So… scripts/env.py:107
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:151
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:34
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:58
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:50
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:58
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:55
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:64
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:16
LOW AIC003 Duplicated implementation block across source files app/apk/src/main/java/com/topjohnwu/mag…:1
LOW AIC003 Duplicated implementation block across source files app/apk-ng/src/main/java/com/topjohnwu/…:55
LOW AIC003 Duplicated implementation block across source files app/apk-ng/src/main/java/com/topjohnwu/…:33
INFO MINED042 [MINED042] Cpp New Without Delete: C++ raw new without RAII / unique_ptr — memory leak ri… native/src/base/include/base.hpp:103
INFO MINED068 [MINED068] Rust Unsafe Block: unsafe { ... } block. Compiler safety guarantees disabled i… native/src/base/misc.rs:13
INFO MINED068 [MINED068] Rust Unsafe Block: unsafe { ... } block. Compiler safety guarantees disabled i… native/src/base/logging.rs:47
INFO MINED068 [MINED068] Rust Unsafe Block: unsafe { ... } block. Compiler safety guarantees disabled i… native/src/base/cxx_extern.rs:22
INFO MINED080 [MINED080] Cpp Using Namespace Std: using namespace std; pollutes the global namespace. native/src/core/deny/cli.cpp:8
INFO MINED080 [MINED080] Cpp Using Namespace Std: using namespace std; pollutes the global namespace. native/src/core/applets.cpp:6
INFO MINED080 [MINED080] Cpp Using Namespace Std: using namespace std; pollutes the global namespace. native/src/base/base.cpp:11
INFO MINED081 [MINED081] Java Printstacktrace: Should use logger, not stack trace to stderr. app/core/src/main/java/com/topjohnwu/ma…:24
Reset to top 5 78 findings available (after auto-suppression of test files + won't-fix)

Issue body (markdown)

## Code-quality scan: `topjohnwu/Magisk`

**Score: 79/100 (C+)**  ·  78 findings  ·  scanned 2026-06-05 09:39 UTC  ·  59,776 LOC

| Severity | Count |
|---|---|
| CRITICAL | 4 |
| HIGH | 47 |
| MEDIUM | 7 |
| LOW | 12 |

📊 [Full filterable report](https://repobility.com/scan/d1773a45-c813-4902-aab8-b41b6533c2e8/)  ·  ![scorecard](https://repobility.com/scan/d1773a45-c813-4902-aab8-b41b6533c2e8/report.png?v=1780652363-s2)

### Top findings

1. **CRITICAL** `MINED022` — C Strcpy
   `native/src/init/mount.cpp:54` · CWE-120 · ✓ Repobility
2. **CRITICAL** `MINED022` — C Strcpy
   `native/src/core/scripting.cpp:80` · CWE-120 · ✓ Repobility
3. **CRITICAL** `MINED022` — C Strcpy
   `native/src/core/deny/logcat.cpp:95` · CWE-120 · ✓ Repobility
4. **CRITICAL** `SEC084` — JS: require() with non-literal
   `app/core/src/main/java/com/topjohnwu/magisk/core/utils/MediaStoreUtils.kt:108`
5. **HIGH** `MINED034` — Python Subprocess Shell True
   `scripts/env.py:120` · CWE-78 · ✓ Repobility

---

**Security note**: this issue is public. If any flagged finding is a real, exploitable vulnerability, please redirect to your `SECURITY.md` policy or open a [private security advisory](https://docs.github.com/en/code-security/security-advisories/guidance-on-reporting-and-writing-information-about-vulnerabilities/privately-reporting-a-security-vulnerability) instead. We're happy to close this and re-submit privately.

---

_Filed automatically. Close this issue if not useful — we won't refile. Full report: https://repobility.com/scan/d1773a45-c813-4902-aab8-b41b6533c2e8/_
Megaproject â high spam risk
Could not determine 'topjohnwu/Magisk' star count (GitHub API rate-limited or unreachable). When in doubt about repo size, prefer opening a focused PR or a discussion rather than an issue.
Open in GitHub to file this issue Cancel

The button opens GitHubâs new-issue page in a new tab. You will see the title + body pre-filled â review, edit if you want, then click GitHubâs "Submit new issue" button. Repobility never posts anything on your behalf.

For real security findings on big repos: use the project's SECURITY.md or private advisory flow instead of a public issue.