Public scan — anyone with this URL can view this analysis. Sign up to track your own repos privately, run scheduled re-scans, and get AI fix prompts via your dashboard.
Sign up free Scan another repo
52 of your 89 findings came from Repobility's proprietary detections. ✓ Repobility tags below mark them.

Scan timing: clone 5.41s · analysis 11.01s · 4.9 MB · GitHub API rate-limit (preflight)

topjohnwu/Magisk

https://github.com/topjohnwu/Magisk · scanned 2026-06-05 09:39 UTC (5 days, 16 hours ago) · 10 languages

162 raw signals (78 security + 84 graph) 43rd percentile · Kotlin · medium (20-100K LoC) System graph score 88 (lower by 27)

File as issue Image
UNIFIED Repobility · multi-layer engine · AI coders

Complete repo analysis

Last scanned 5 days, 16 hours ago · v2 · 55 actionable findings from 2 signal sources. 65 repeated signals grouped for readability. Security checks, system graph analysis, and verified AI-agent feedback are merged into one review queue.

JSON
Combined
79.2
/100
Security checks
70
27 findings
System graph
88
77.8% cov · 28 findings
Critical
0
click to filter
Agents
6
0 votes
Crowd
0
reported
Score breakdown â 2026-05-18-v5
Component Sub-score Weight Contribution
structure_score 65.0 0.15 9.75
security_score 85.5 0.25 21.38
testing_score 15.0 0.20 3.00
documentation_score 61.0 0.15 9.15
practices_score 67.0 0.15 10.05
code_quality 72.9 0.10 7.29
Overall 1.00 60.6
Severity distribution — click a segment to filter
Active filters: excluding tests × Reset all
Severity: Critical 0 High 7 Medium 12 Low 19 9-Layer: Software Security Quality Integrity Frontend Hardware Data Network Cicd Source: Security checks 27 System graph 28 Crowd 0 Layer: Security 15 Quality 24 Software 13 Cicd 1 Api 1 Frontend 1
Scan summary Quality grade C+ (61/100). Dimensions: security 86, maintainability 65. 78 findings (22 security). 59,776 lines analyzed.

Showing 38 of 55 actionable findings. 120 raw detector signals were grouped into reader-sized issues. Click TP / FP to vote on a finding's accuracy — votes adjust the confidence weighting and improve detection across the platform.

high Security checks quality Quality conf 1.00 ✓ Repobility 3 occurrences [MINED029] Kotlin Null Bang: x!! throws NullPointerException if x is null. Bypasses Kotlins null safety.
Review and fix per the pattern semantics. See CWE-476 / for context.
3 files, 3 locations
app/apk-ng/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt:120
app/apk/src/main/java/com/topjohnwu/magisk/arch/BaseFragment.kt:94
app/build-logic/src/main/java/Plugin.kt:25
high Security checks quality Quality conf 1.00 ✓ Repobility [MINED034] Python Subprocess Shell True: subprocess(..., shell=True) enables command injection.
Review and fix per the pattern semantics. See CWE-78 / for context.
scripts/env.py:120
low Security checks security Injection conf 0.80 [SEC005] Command Injection Risk: Unsafe shell execution or eval of user input.
Use subprocess with shell=False and a list of args. Never eval user input.
app/stub/src/main/java/com/topjohnwu/magisk/net/Request.java:138
high Security checks security path traversal conf 0.80 [SEC013] Path Traversal — User Input in File Path: User-controlled input used in file path without sanitization. Allows reading arbitrary files.
Use os.path.realpath() and verify the path starts with your expected base directory. Use secure_filename() for uploads.
app/core/src/main/java/com/topjohnwu/magisk/core/signing/JarMap.java:26
high Security checks quality Quality conf 1.00 ✓ Repobility 10 occurrences `self.arg_list_cpp` used but never assigned in __init__
Method `cpp_fn_type` of class `JNIMethod` reads `self.arg_list_cpp`, but no assignment to it exists in __init__ (and no class-level fallback). This raises AttributeError the first time the method runs against an instance.
lines 61, 64, 108, 109, 113, 114, 115, 117, +2 more
native/src/core/zygisk/gen_jni_hooks.py:61, 64, 108, 109, 113, 114, 115, 117, +2 more (10 hits)
high Security checks software dependencies conf 0.90 ✓ Repobility Binary file `app/gradle/wrapper/gradle-wrapper.jar` committed in source repo
`app/gradle/wrapper/gradle-wrapper.jar` is a .jar binary (43,764 bytes) committed to a repo that otherwise has 344 source files. Trojan binaries inside otherwise-normal source repos are a known supply-chain attack: a compromised dependency or PR slips in a binary that gets executed by build scripts.
app/gradle/wrapper/gradle-wrapper.jar:1
low Security checks cicd CI/CD security conf 0.90 ✓ Repobility 26 occurrences GitHub Action is tag-pinned rather than SHA-pinned
Action `actions/checkout` pinned to mutable ref `@v6` uses a mutable tag or branch. Pin external actions to a reviewed full commit SHA when the workflow is security-sensitive.
lines 23, 42, 49, 64, 93, 96, 110, 129, +5 more
.github/workflows/build.yml:23, 42, 49, 64, 93, 96, 110, 129, +5 more (26 hits)
CI/CD securitySupply chainGitHub Actions
high Security checks software dependencies conf 0.88 rsa: RUSTSEC-2023-0071
Marvin Attack: potential key recovery through timing sidechannels
native/src/Cargo.lock
high System graph security security conf 1.00 Insecure pattern 'exec_used' in app/stub/src/main/java/com/topjohnwu/magisk/net/Request.java:86
Found a known-risky pattern (exec_used). Review and replace if possible.
app/stub/src/main/java/com/topjohnwu/magisk/net/Request.java:86 Exec used
low Security checks security Injection conf 0.50 [SEC005] Command Injection Risk: Unsafe shell execution or eval of user input.
Use subprocess with shell=False and a list of args. Never eval user input.
scripts/env.py:120
medium Security checks security path traversal conf 1.00 [SEC012] ZipSlip — Archive Path Traversal: Archive extraction without path validation allows writing files outside the target directory.
Validate extracted paths with os.path.realpath() and ensure they stay within the target directory.
app/core/src/main/java/com/topjohnwu/magisk/core/signing/JarMap.java:131
low Security checks quality Error handling conf 0.55 ✓ Repobility Broad exception handler needs review
This handler catches Exception/BaseException. It is actionable when it swallows errors without logging, re-raising, or returning a structured error. Handlers that intentionally convert exceptions into typed error results should not be treated as high risk.
scripts/env.py:74 Error handlingquality
medium System graph security security conf 1.00 Insecure pattern 'subprocess_shell_true' in scripts/env.py:124
Found a known-risky pattern (subprocess_shell_true). Review and replace if possible.
scripts/env.py:124 Subprocess shell true
medium System graph security security conf 1.00 Insecure pattern 'weak_hash' in app/core/src/main/java/com/topjohnwu/magisk/core/signing/SignApk.java:127
Found a known-risky pattern (weak_hash). Review and replace if possible.
app/core/src/main/java/com/topjohnwu/magisk/core/signing/SignApk.java:127 Weak hash
medium System graph security security conf 1.00 Insecure pattern 'weak_hash' in native/src/boot/cli.rs:264
Found a known-risky pattern (weak_hash). Review and replace if possible.
native/src/boot/cli.rs:264 Weak hash
medium System graph security security conf 1.00 Insecure pattern 'weak_hash' in native/src/boot/sign.rs:34
Found a known-risky pattern (weak_hash). Review and replace if possible.
native/src/boot/sign.rs:34 Weak hash
medium System graph security security conf 1.00 Insecure pattern 'weak_hash' in scripts/app_functions.sh:92
Found a known-risky pattern (weak_hash). Review and replace if possible.
scripts/app_functions.sh:92 Weak hash
medium System graph security security conf 1.00 Insecure pattern 'weak_hash' in scripts/boot_patch.sh:138
Found a known-risky pattern (weak_hash). Review and replace if possible.
scripts/boot_patch.sh:138 Weak hash
medium System graph security security conf 1.00 Insecure pattern 'weak_hash' in scripts/util_functions.sh:544
Found a known-risky pattern (weak_hash). Review and replace if possible.
scripts/util_functions.sh:544 Weak hash
medium System graph quality Integrity conf 1.00 Network/subprocess call without timeout or try/except — build.py:101
`subprocess.run(...)` here lacks both a `timeout=` arg and an enclosing try/except. This is exactly the class of bug that took down our git-clone earlier (HTTP/2 stream cancel surfaced as a fatal). Add a `timeout=` and wrap in try/except, or use a wrapper that retries.
runtime safetyRobustness
medium System graph quality Integrity conf 1.00 Network/subprocess call without timeout or try/except — scripts/env.py:167
`subprocess.run(...)` here lacks both a `timeout=` arg and an enclosing try/except. This is exactly the class of bug that took down our git-clone earlier (HTTP/2 stream cancel surfaced as a fatal). Add a `timeout=` and wrap in try/except, or use a wrapper that retries.
runtime safetyRobustness
medium System graph security Coverage conf 1.00 No auth library detected
The scanner did not find any standard auth library (JWT, OAuth, NextAuth, Auth0, etc.). Either auth lives in custom code, in a separate service, or is missing.
auth
medium System graph quality Tests conf 1.00 Very low test-to-source ratio
0 test file(s) for 73 source file(s) (ratio 0.00). Consider adding integration or unit tests for critical paths.
Coverage
low Security checks quality Quality conf 0.60 11 occurrences Duplicated implementation block across source files
Duplicate implementation blocks are maintenance debt. Keep them visible, but they are not a high-severity defect unless the duplicated logic is security-sensitive or drifting.
11 files, 11 locations
app/apk-ng/src/main/java/com/topjohnwu/magisk/ui/module/ActionScreen.kt:33
app/apk-ng/src/main/java/com/topjohnwu/magisk/ui/superuser/SuperuserScreen.kt:55
app/apk/src/main/java/com/topjohnwu/magisk/arch/AsyncLoadViewModel.kt:1
app/apk/src/main/java/com/topjohnwu/magisk/ui/deny/AppProcessInfo.kt:16
app/apk/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt:64
app/apk/src/main/java/com/topjohnwu/magisk/ui/log/LogViewModel.kt:55
app/apk/src/main/java/com/topjohnwu/magisk/ui/module/ActionFragment.kt:58
app/apk/src/main/java/com/topjohnwu/magisk/ui/module/ActionViewModel.kt:50
duplicationquality
low System graph security security conf 1.00 Insecure pattern 'debug_true' in build.py:486
Found a known-risky pattern (debug_true). Review and replace if possible.
build.py:486 Debug true
low System graph quality Integrity conf 1.00 2 occurrences Near-duplicate function bodies in 2 places
Functions with the same first-5-line body hash: native/src/core/zygisk/gen_jni_hooks.py:body, native/src/core/zygisk/gen_jni_hooks.py:body This is *the* AI-coder failure mode (4× more duplication in vibe-coded repos — see https://jw.hn/ai-code-hygiene). Consolidate or document why they're separate.
2 occurrences
repo-level (2 hits)
duplicatesduplication
low System graph quality Integrity conf 1.00 Near-duplicate function bodies in 4 places
Functions with the same first-5-line body hash: native/src/core/zygisk/gen_jni_hooks.py:hook_target, native/src/core/zygisk/gen_jni_hooks.py:hook_target, native/src/core/zygisk/gen_jni_hooks.py:hook_target, native/src/core/zygisk/gen_jni_hooks.py:hook_target This is *the* AI-coder failure mode (4×…
duplicatesduplication
low System graph quality Integrity conf 1.00 Old/deprecated-named symbol `ServerSpecializeArgs_v1` in native/src/core/zygisk/gen_jni_hooks.py:137
Names with suffixes like `_old`, `_v1`, `_deprecated` usually indicate replaced-but-not-removed code (typical AI-coder leftover). Confirm and delete, or rename if it's the active version.
old markerDead code
low System graph software Dead code conf 1.00 Possibly dead Python function: build_stub
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:359
low System graph software Dead code conf 1.00 Possibly dead Python function: cargo_cli
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:498
low System graph software Dead code conf 1.00 Possibly dead Python function: clippy_cli
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:474
low System graph software Dead code conf 1.00 Possibly dead Python function: gen_ide
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:431
low System graph software Dead code conf 1.00 Possibly dead Python function: patch_avd_file
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:603
low System graph software Dead code conf 1.00 Possibly dead Python function: rm_on_error
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:80
low System graph software Dead code conf 1.00 Possibly dead Python function: setup_avd
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:593
low System graph software Dead code conf 1.00 Possibly dead Python function: setup_ndk
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:509
low System graph software Dead code conf 1.00 Possibly dead Python function: setup_rustup
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
build.py:527
low System graph software Dead code conf 1.00 Possibly dead Python function: wrapper
No callers detected by AST scan in this repo. Could be exported for external callers or a framework handler.
scripts/env.py:59
For AI agents: Voting guide (TP/FP) MCP manifest Stdio wrapper SARIF Integrate Findings queue Vote TP/FP on findings to calibrate the engine.
For AI agents + API integrations
Email me when this repo regresses
Free. We re-scan periodically; new criticals → your inbox. No signup required for the scan itself.
API access

This page is publicly accessible at: https://repobility.com/scan/d1773a45-c813-4902-aab8-b41b6533c2e8/

To check status programmatically (no auth required): 

curl -s https://repobility.com/api/v1/public/scan/d1773a45-c813-4902-aab8-b41b6533c2e8/

Important — please don't re-submit the same URL repeatedly. The submission endpoint is idempotent: re-submitting the same git URL returns this same scan_token, not a new one. To re-scan this repo, sign up free and use the dashboard.